Re: [PATCH 3/3] spi: rspi: Add runtime PM support, using spi core auto_runtime_pm

[Mark Brown]

On Tue, Mar 11, 2014 at 02:35:15PM +0100, Geert Uytterhoeven wrote:
> On Tue, Mar 11, 2014 at 2:26 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Tue, Mar 11, 2014 at 02:10:31PM +0100, Geert Uytterhoeven wrote:

> >> Can you please elaborate what should be fixed?

> >> If I disable CONFIG_PM_RUNTIME, the kernel prints:

> >>     Runtime PM disabled, clock forced on.

> >> and the clock is enabled all the time (verified by looking at the clock
> >> registers)?

> > That's very SH specific and doesn't apply in the general case (I would
> > not be surprised if future SH updates broke it...).

> Note that this is from drivers/base/power/clock_ops.c

> So what should I do instead?

Oh, is this manipulating the clock managed by the power domains?  If
that's the case don't worry about it, it's fine.  I'd thought it was
another clock.

Attachment: signature.asc
Description: Digital signature