Re: [PATCH] devicetree: bindings: gpio-davinic: fix documentation

From: Linus Walleij
Date: Tue Mar 11 2014 - 06:22:13 EST


On Thu, Mar 6, 2014 at 6:58 AM, Prabhakar Lad
<prabhakar.csengg@xxxxxxxxx> wrote:

> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
>
> This patch adds missing #gpio-cells and also adds a
> usage example for leds.
>
> Reported-by: Alexander Holler <holler@xxxxxxxxxxxxx>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Thanks, patch applied.

Note:

> + - second cell is used to specify optional parameters (unused)
(...)
> + gpios = <&gpio 10 GPIO_ACTIVE_HIGH>;

So you're using the unused cell.

However it is maybe nice to put things like that in there as it
sort of documents the system so whatever.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/