Re: [PATCH] module: LLVMLinux: Remove unused function warning from __param_check macro

[Behan Webster]

On 03/10/14 23:11, Rusty Russell wrote:
> behanw@xxxxxxxxxxxxxxxxxx writes:
> > From: Mark Charlebois <charlebm@xxxxxxxxx>
> >
> > This code makes a compile time type check that is optimized away. Clang
> > complains that it generates an unused function.
> >
> > I believe GCC won't complain for a static inline fuction but would if it
> > was just a static function.
> >
> > Adding the unused attribute to the function declaration removes the warning.
> >
> > This code works for both gcc and clang.
> >
> > Signed-off-by: Mark Charlebois <charlebm@xxxxxxxxx>
> > Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
> Please include the actual warning clang spits out.  That helps because
> (1) I know what you're referring to, and
> (2) it helps others if they are later googling for the error.
Nice! Will fix.

> I don't have any huge objections to this patch (__always_unused) though.
Already in the posted v2 patch.

However I will post a v3 with your other suggested changes to the commit 
message.

Thanks,

Behan

--
Behan Webster
behanw@xxxxxxxxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/