Re: [PATCH RT 2/5] a few open coded completions

[Steven Rostedt]

On Tue, 11 Mar 2014 02:06:46 +0000
Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:


> > I don't run a make allmodconfig as I do on my upstream work. Maybe I'll
> > have to add that to the mix.
> 
> You can enable all the affected code with:
> 
> CONFIG_HERMES=m
> CONFIG_ORINOCO_USB=m
> CONFIG_USB_GADGET=m
> CONFIG_USB_FUNCTIONFS=m
> CONFIG_USB_GADGETFS=m

Thanks, I ran an allmodconfig, and you're right, the orinoco driver
failed to compile on v3.2-rt. I ran allmodconfig on 3.10-rt and it
passed fine. Seems that one of the headers there pulls in swait.

Looking deeper, 3.10-rt has completion as a simple-wait, and
completion.h pulls in wait-simple.h, which is why it works there. 3.2
does not have completions there. I wonder if I should pull in the patch
that converts completions into swaits, and that may fix other locations
as well.

I'll give it a try.

Thanks,

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/