Re: [PATCH v2] x86: Remove compat vdso support

From: Linus Torvalds
Date: Mon Mar 10 2014 - 21:39:18 EST


On Mon, Mar 10, 2014 at 6:03 PM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
>
> This is a bit of an abuse of the no-breaking-userspace policy.

No it's not, because it won't be applied.

You need to fix it.

I'm not sure what goes wrong, since it *looks* like you handle the
"vdso_enabled" thing correctly, so I find it surprising that you say
that

echo 0 >/proc/sys/abi/vsyscall32

makes it work, since it should be zero already, and that echo should
be a no-op. But maybe I'm missing something.

Maybe you can just fake the boot parameter and fix the OpenSuSE
breakage that way (presumably that "init" sees it if it's some
user-space setup thing), but I'd like to know why that "echo 0" works,
but just initializing it to zero does not?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/