Re: [PATCH 4/8] mfd: lpc_ich: Add support for iTCO v3

From: Guenter Roeck
Date: Mon Mar 10 2014 - 21:02:53 EST


On Mon, Mar 10, 2014 at 04:34:54PM -0500, Peter Tyser wrote:
> Some newer Atom CPUs, eg Avoton and Bay Trail, use slightly different
> register layouts for the iTCO than the current v1 and v2 iTCO.
> Differences from previous iTCO versions include:
> - The ACPI space is enabled in the "ACPI base address" register instead
> of the "ACPI control register"
>
> - The "no reboot" functionality is set in the "Power Management
> Configuration" register instead of the "General Control and Status"
> (GCS) register or PCI configuration space.
>
> - The "ACPI Control Register" is not present on v3. The "Power
> Management Configuration Base Address" register resides at the same
> address is Avoton/Bay Trail.
>
> To differentiate these newer chipsets create a new v3 iTCO version and
> update the MFD driver to support them.
>
> Signed-off-by: Peter Tyser <ptyser@xxxxxxxxxxx>
> Tested-by: Rajat Jain <rajatjain@xxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: James Ralston <james.d.ralston@xxxxxxxxx>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/