Re: [PATCH] mfd: wm5102: Mark register 0x19 readable

From: Lee Jones
Date: Mon Mar 10 2014 - 12:38:27 EST


> From: Mark Brown <broonie@xxxxxxxxxx>
>
> During init the core checks if the wm5102 has finished starting by reading
> register 0x19 and looking at the value. This read always fails since this
> is not a readable register, mark it as being one.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index f4668d39e542..07f024fd4ded 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -1016,6 +1016,7 @@ static bool wm5102_readable_register(struct device *dev, unsigned int reg)
> case ARIZONA_WRITE_SEQUENCER_CTRL_0:
> case ARIZONA_WRITE_SEQUENCER_CTRL_1:
> case ARIZONA_WRITE_SEQUENCER_CTRL_2:
> + case 0x19:

Can we have a #define for these please?

> case ARIZONA_WRITE_SEQUENCER_PROM:
> case ARIZONA_TONE_GENERATOR_1:
> case ARIZONA_TONE_GENERATOR_2:

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/