Re: [PATCH] cpufreq: Reformat printk() statement

From: Viresh Kumar
Date: Mon Mar 10 2014 - 00:15:28 EST


On 10 March 2014 12:07, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Mon, 2014-03-10 at 11:53 +0800, Viresh Kumar wrote:
>> On 7 March 2014 01:34, Soren Brinkmann <soren.brinkmann@xxxxxxxxxx> wrote:
>> > Reformat a printk statement to:
>> > - use pr_warn
>> > - bring the whole string into a single line in favor of being able to
>> > grep for the message (ignoring the 80 char limit)
>> >
>> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
> []
>> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
>
> A more comprehensive patch would be to:
>
> Add missing newlines
> Coalesce format fragments
> Convert printks to pr_<level>
> Align arguments
> ---
> drivers/cpufreq/cpufreq.c | 85 ++++++++++++++++++++++-------------------------
> 1 file changed, 40 insertions(+), 45 deletions(-)

Thanks..

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/