Re: [PATCH] Staging: comedi: Fix 80-char line limit style issue in addi_apci_1500.c

[Greg Kroah-Hartman]

On Sat, Mar 08, 2014 at 02:38:38PM -0500, Conrad Meyer wrote:
> Fix minor checkpatch.pl style issues (80-char line limits) in
> addi_apci_1500.c.
> 
> Signed-off-by: Conrad Meyer <cse.cem@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/addi_apci_1500.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1500.c b/drivers/staging/comedi/drivers/addi_apci_1500.c
> index 74f7ace..f23ca3d 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1500.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1500.c
> @@ -26,11 +26,13 @@ static const struct addi_board apci1500_boardtypes[] = {
>                 .di_read                = i_APCI1500_Initialisation,
>                 .di_write               = i_APCI1500_StartStopInputEvent,
>                 .di_bits                = apci1500_di_insn_bits,
> -               .do_config              = i_APCI1500_ConfigDigitalOutputErrorInterrupt,
> +               .do_config              =
> +                       i_APCI1500_ConfigDigitalOutputErrorInterrupt,

No, as horrible as too long of a line it might be, this is worse.  How
about renaming the function to be more "sane" which would cause it to be
shorter here, fixing the line limit.

Something like config_output() would be better, right?

>                 .do_write               = i_APCI1500_WriteDigitalOutput,
>                 .do_bits                = i_APCI1500_ConfigureInterrupt,
>                 .timer_config           = i_APCI1500_ConfigCounterTimerWatchdog,
> -               .timer_write            = i_APCI1500_StartStopTriggerTimerCounterWatchdog,
> +               .timer_write            =
> +                       i_APCI1500_StartStopTriggerTimerCounterWatchdog,

Same here, "timer_watchdog()"?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/