Re: [RFC][PATCH] audit: Simplify by assuming the callers socket buffer is large enough

From: Andrew Morton
Date: Tue Mar 04 2014 - 17:50:49 EST


On Tue, 04 Mar 2014 14:41:16 -0800 ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:

> David Miller <davem@xxxxxxxxxxxxx> writes:
>
> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Date: Tue, 4 Mar 2014 13:30:04 -0800
> >
> >> On Fri, 28 Feb 2014 20:50:19 -0800 ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:
> >>
> >>>
> >>> Modify audit_send_reply to directly use a non-blocking send and
> >>> to return an error on failure (if anyone cares).
> >>>
> >>> Modify audit_list_rules_send to use audit_send_reply and give up
> >>> if we can not send a packet.
> >>>
> >>> Merge audit_list_rules into iaudit_list_rules_send as the code
> >>> is now sufficiently simple to not justify to callers.
> >>>
> >>> Kill audit_send_list, audit_send_reply_thread because using
> >>> a separate thread for replies is not needed when sending
> >>> packets syncrhonously.
> >>
> >> Nothing much seems to be happening here?
>
> Well you picked up the patch that fixes the worst of the bugs that I was
> complaining about. Beyond that I don't know what makes sense.

Oh, so I did. I wasn't planning on merging it myself, hoping that
someone who hasaclue will step in. Help.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/