Re: [PATCH] staging: rtl8187se: fix checkpatch.pl issues

[Greg KH]

On Thu, Feb 20, 2014 at 01:05:31AM -0700, axel.rasmussen1@xxxxxxxxx wrote:
> From: Axel Rasmussen <axel.rasmussen1@xxxxxxxxx>
> Date: Mon, 17 Feb 2014 23:50:05 -0700
> Subject: [PATCH] staging: rtl8187se: fix checkpatch.pl issues

Please just use 'git send-email' so I don't have to hand-edit the patch
and strip this out :(

> 
> Reformatted many lines which were too long, replaced various printk
> calls with appropriate netdev_* calls, and fixed some spelling errors.

You did multiple things here to this patch, which should be a big hint
that you need to break it up into smaller pieces, each one doing just
one thing.  Please do so, otherwise as it is, this patch is way too big
to review.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/