Re: [PATCH 2/2] spi: Add Qualcomm QUP SPI controller support

From: Josh Cartwright
Date: Fri Feb 07 2014 - 12:24:26 EST


Hey Mark-

On Fri, Feb 07, 2014 at 05:18:34PM +0000, Mark Brown wrote:
> On Fri, Feb 07, 2014 at 10:51:27AM -0600, Josh Cartwright wrote:
>
> > config SPI_QUP
> > tristate "Qualcomm SPI Support with QUP interface"
> > depends on OF
> > depends on ARM
>
> Does this really depend on ARM? If so why?

The ARM dependency is there for the use of _relaxed io accessor
variants.

> > depends on ARCH_MSM_DT || COMPILE_TEST
>
> > With Kumar's pending the ARCH_MSM_DT -> ARCH_QCOM rename, we'll
> > introduce a arm-soc/spi tree dependency here that we'll need to keep
> > track of.
>
> It seems simpler to just depend on MSM_DT || ARCH_QCOM or whatever.

ARCH_MSM_DT is going away, so maybe this is the best option for the
short term (a later patch can remove ARCH_MSM_DT from here at some point
in the future).

Josh

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/