Re: [PATCH] regulator: core: Make regulator object reflectconfigured voltage

From: Mark Brown
Date: Tue Feb 04 2014 - 15:00:36 EST


On Tue, Feb 04, 2014 at 11:09:03AM -0800, Bjorn Andersson wrote:

> I have a regulator that's being configured from DT as:
> regulator-min-microvolt = <2950000>;
> regulator-max-microvolt = <2950000>;

> In the consumer I do regulator_set_voltage(2.95V).

> As min == max the voltage is applied by the regulator framework on registration
> of the regulator; and the regulator_set_voltage() fails as
> REGULATOR_CHANGE_VOLTAGE is not set for this regulator.

So we should be changing the code to allow a set_voltage() that sets the
voltage to the existing voltage regardless of constraints allowing a
change then - that's what the underlying issue is. Your change wouldn't
cover the case where the hardware defualt is being used for example.

Attachment: signature.asc
Description: Digital signature