Re: [PATCH -v2] x86, microcode, AMD: Sanity-check initrd image

From: Borislav Petkov
Date: Mon Feb 03 2014 - 15:33:34 EST


On Mon, Feb 03, 2014 at 03:28:51PM -0500, Boris Ostrovsky wrote:
> On 02/03/2014 02:52 PM, Borislav Petkov wrote:
> >On Mon, Feb 03, 2014 at 02:37:34PM -0500, Boris Ostrovsky wrote:
> >>It exploded when 'if (!container)' check was done *after* relocation,
> >>which made container non-zero. If you do the check *before* then I
> >>think you will catch the fact that container is empty.
> >Ah, right, this was it.
> >
> >Ok, just remove the signature check then and give it a try pls:
>
> Yes, this fixes the bug. And it loads microcode for a good binary.
>
> For these two patches:
> Tested-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
>
> (You might want to rename the final patch to something else since
> you are not checking the blob anymore).

Yes, will do. It'll be one patch though - it is still small enough. I'll
send it as a reply to this message.

Thanks for your help!

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/