Re: [PATCH] drivers: staging: lustre: lustre: include: add"__attribute__((packed))" for the related union

From: Dan Carpenter
Date: Mon Feb 03 2014 - 03:59:38 EST


On Sat, Feb 01, 2014 at 09:57:39PM +0800, Chen Gang wrote:
> It seems, our kernel still stick to treate 'pack' region have effect
> with both 'align' and 'sizeof'.
>

It's not about packed regions. It's about unions. It's saying the
sizeof() a union is a multiple of 4 unless it's packed.

union foo {
short x;
short y;
};

The author intended the sizeof(union foo) to be 2 but on metag arch then
it is 4.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/