Re: [PATCH] memcg: fix mutex not unlocked on memcg_create_kmem_cachefail path

From: David Rientjes
Date: Thu Jan 30 2014 - 17:13:27 EST


On Thu, 30 Jan 2014, Andrew Morton wrote:

> > Why? We already construct the name in memcg_create_kmem_cache()
> > appropriately, we just want to avoid the kstrdup() in
> > kmem_cache_create_memcg() since it's pointless like my patch does.
>
> oh, OK, missed that.
>
> The problem now is that the string at kmem_cache.name is PATH_MAX
> bytes, and PATH_MAX is huuuuuuuge.
>

It always was. Google uses pretty long memcg names (although admittedly
not as long as PATH_MAX!) and it hasn't caused any problem with
/proc/slabinfo or slabtop(1).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/