Re: [RFCv2,1/2] v4l2-controls.h: add addtional Flash fault bits

From: Hans Verkuil
Date: Tue Jan 28 2014 - 02:05:35 EST


On 01/28/2014 07:55 AM, Daniel Jeong wrote:
> Add additional FLASH Fault bits to dectect faults from chip.
> Some Flash drivers support UVLO, IVFM, NTC Trip faults.
> UVLO : Under Voltage Lock Out Threshold crossed
> IVFM : IVFM block reported and/or adjusted LED current Input Voltage Flash Monitor trip threshold
> NTC : NTC Threshold crossed. Many Flash drivers have a pin and the fault bit to
> serves as a threshold detector for negative temperature coefficient (NTC) thermistors.

Please document these new flags as well in Documentation/DocBook/media/v4l/controls.xml.

Regards,

Hans

>
> Signed-off-by: Daniel Jeong <gshark.jeong@xxxxxxxxx>
> ---
> include/uapi/linux/v4l2-controls.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h
> index 1666aab..01d730c 100644
> --- a/include/uapi/linux/v4l2-controls.h
> +++ b/include/uapi/linux/v4l2-controls.h
> @@ -803,6 +803,9 @@ enum v4l2_flash_strobe_source {
> #define V4L2_FLASH_FAULT_SHORT_CIRCUIT (1 << 3)
> #define V4L2_FLASH_FAULT_OVER_CURRENT (1 << 4)
> #define V4L2_FLASH_FAULT_INDICATOR (1 << 5)
> +#define V4L2_FLASH_FAULT_UVLO (1 << 6)
> +#define V4L2_FLASH_FAULT_IVFM (1 << 7)
> +#define V4L2_FLASH_FAULT_NTC_TRIP (1 << 8)
>
> #define V4L2_CID_FLASH_CHARGE (V4L2_CID_FLASH_CLASS_BASE + 11)
> #define V4L2_CID_FLASH_READY (V4L2_CID_FLASH_CLASS_BASE + 12)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/