Re: [PATCH] Use LOAD_PHYSICAL_ADDR in vmlinux.lds.S

From: David Rientjes
Date: Sun Jan 26 2014 - 16:12:46 EST


On Sun, 26 Jan 2014, Zhihui Zhang wrote:

> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index da6b35a..e81bf49 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -81,11 +81,10 @@ PHDRS {
>
> SECTIONS
> {
> -#ifdef CONFIG_X86_32
> . = LOAD_OFFSET + LOAD_PHYSICAL_ADDR;
> +#ifdef CONFIG_X86_32
> phys_startup_32 = startup_32 - LOAD_OFFSET;
> #else
> - . = __START_KERNEL;
> phys_startup_64 = startup_64 - LOAD_OFFSET;
> #endif
>

Makes sense, but any reason to not make LOAD_PHYSICAL_ADDR to use ALIGN()?

(You'll also want to prefix the patch title in the subject line with
"x86, boot:" and cc x86@xxxxxxxxxx on patches like this.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/