Re: [PATCH 1/1] suspend: make sync() on suspend-to-RAM optional

From: Pavel Machek
Date: Sun Jan 26 2014 - 16:09:04 EST


Hi!

> From: Len Brown <len.brown@xxxxxxxxx>
>
> Linux suspend-to-RAM was unreliable when first developed,
> and so sys_sync() was invoked inside the kernel at the
> start of every suspend flow.
>
> Today, many devices are invoking suspend with
> high reliability and high frequency, and they don't
> want to be forced to pay for sync on every suspend.
>
> So here we make it optional.
> De-select CONFIG_PM_SLEEP_SYNC to delete the call entirely.
> or keep CONFIG_PM_SLEEP and you can now clear the
> sys/power/sleep_sync attribte to disable the sync
> from user-space.

Dunno. Config option plus sysfs attribute is overdoing it a bit.
Maybe we could do

echo memfast > state

to enter suspend without sync? Patch should be simpler that way,
and we won't have to keep the state...

Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/