Re: [PATCH -tip 4/8] perf-probe: Use the actual address instead ofthe symbol name

[Masami Hiramatsu]

(2014/01/24 21:13), Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 24, 2014 at 10:49:32AM +0900, Masami Hiramatsu escreveu:
>> (2014/01/24 1:12), Steven Rostedt wrote:
>>> On Thu, 23 Jan 2014 11:52:11 -0300
>>> Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:
>>>
>>>> Em Thu, Jan 23, 2014 at 02:29:55AM +0000, Masami Hiramatsu escreveu:
>>>>> Since several local symbols can have same name (e.g. t_show),
>>>>> we need to use the actual address instead of symbol name for
>>>>> those points. Note that this works only with debuginfo.
>>>>>
>>>>> E.g. without this change;
>>>>> ----
>>>>
>>>> Please use spaces after dashed lines, this is even as (or more)
>>>> important as prefixing # lines, as this makes everything after the ---
>>>> line and the patch itself to be ignored.
>>>>
>>
>> Oops, I thought that "----" was safe...
>>
>>> You recommend after? I found adding a single space before the dashes
>>> better, as that way I know I added one and didn't forget to.
>>
>> OK, I'll add at least one space before dashes.
>>
>> BTW, should "#" have two spaces instead of one?
> 
> I suggest using two spaces before --- and #, that is what I do and edit
> patches from others when merging, so that would save me some time while
> processing patches.

OK, I'll do it.
I think it also would better change checkpatch.pl to handle it.

Thank you very much! :)

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/