Re: ipi_redirect vs rq_affinity

From: Jens Axboe
Date: Fri Jan 24 2014 - 14:11:41 EST


On Fri, Jan 24 2014, Christoph Hellwig wrote:
> Hi Jens,
>
> it seems like blk-mq uses the ipi_redirect attribute in pretty much the
> same way as the old blk-softirq code used the rq_affinity one, except
> that the old code has an additional option to direct into any core in
> the current package.
>
> Is there any good reason to not reuse the old name and semantics?

It is pretty much the same. I don't like the semantics of the old one,
where it's 0/1/2 for off/on/different-on, though. Seems like now would
be a good time to clean it up.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/