Re: [PATCH net-next] bonding: Use do_div to divide 64 bit numbers

[Zoltan Kiss]

On 23/01/14 21:18, Nikolay Aleksandrov wrote:
> > Hi Zoltan,
> > Thanks for fixing this, a few comments though:
> > bond->params.miimon can be 0 here that's why there's a check afterwards,
> > also please separate the local variable definitions from the body with a
> > new line.
> > The same applies for downdelay.
> >
> > Nik
> In fact since we don't need the u64 and newval->value is limited to
> INT_MAX, can't we simply cast it to (int) and avoid the do_div entirely ?
Yep, that's even better, thanks for fixing it!

Zoli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/