Re: [PATCH v4 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver

From: Linus Walleij
Date: Thu Jan 16 2014 - 08:19:18 EST


On Sat, Dec 21, 2013 at 3:13 AM, Sherman Yin <syin@xxxxxxxxxxxx> wrote:

'> Adds pinctrl driver for Broadcom Capri (BCM281xx) SoCs.
>
> Signed-off-by: Sherman Yin <syin@xxxxxxxxxxxx>
> Reviewed-by: Christian Daudt <bcm@xxxxxxxxxxxxx>
> Reviewed-by: Matt Porter <matt.porter@xxxxxxxxxx>
> ---
> v4: - PINCTRL selected in Kconfig, PINCTRL_CAPRI selected in bcm_defconfig
> - make use of regmap
> - change CAPRI_PIN_UPDATE from macro to inline function.
> - Handle pull-up strength arg in Ohm instead of enum

Patch applied. It is really good now! It's late before the merge
window, but you've done a tremendous work on this driver and
I don't want to delay its deployment further.

But note:

> arch/arm/configs/bcm_defconfig | 1 +
> arch/arm/mach-bcm/Kconfig | 1 +

I've optimistically applied these two hunks of the patch as well,
but if there is any conflict with the ARM SoC tree I will just rebase
the patch and pull these *out*.

ARM SoC maintainers: be warned if something collides.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/