Re: [PATCH Resend] cpufreq: remove sysfs files for CPU which failedto come back after resume

From: Viresh Kumar
Date: Mon Dec 23 2013 - 05:45:15 EST


On 23 December 2013 14:53, Bjørn Mork <bjorn@xxxxxxx> wrote:
> Confirmed. With that patch on top of the current pm-cpufreq branch all
> functionality is restored and there are no regressions AFAICS.

Thanks..

> I still don't understand why you want to add this hackish half-assed
> suspend implementation

As it is working currently, until we have a proper solution which I am
already discussing with Rafael:

https://lkml.org/lkml/2013/11/22/66

> But if you really want to implement suspend/resume, then you
> do need to keep the whole device and not just the sysfs files. Keeping
> the attribute files allow you to save and restore changed permissions,
> but it doesn't save any user modified settings.

Which settings are you talking about? I thought we are preserving all
files..

> Well, not my problem... Just wondering really.

:)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/