Re: [PATCH v12 4/4] ARM: dts: Exynos5420: Add device nodes for TMUblocks

From: Kukjin Kim
Date: Fri Dec 20 2013 - 16:01:54 EST


On 12/20/13 14:11, Naveen Krishna Chatradhi wrote:
Exynos5420 SoC has per core thermal management unit.
5 TMU channels 4 for CPUs and 5th for GPU.

This patch adds the device tree nodes to the DT device list.

Nodes carry the misplaced second base address and the second
clock to access the misplaced base address.

Signed-off-by: Leela Krishna Amudala<l.krishna@xxxxxxxxxxx>
Signed-off-by: Naveen Krishna Chatradhi<ch.naveen@xxxxxxxxxxx>
Signed-off-by: Andrew Bresticker<abrestic@xxxxxxxxxxxx>
---
Changes since v11:
changed the secondary clock name to "tmu_triminfo_apbif"
from "tmu_apbif_triminfo"

Changes since previous version:
1. used lables instead of comment lines
2. pass the same clock as trimfo_apbif clock for TMU channel 2
3. Fixed a coding style problem pointed by Tomasz

arch/arm/boot/dts/exynos5420.dtsi | 40 +++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index b1fa334..c62cde6 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -402,4 +402,44 @@
clock-names = "gscl";
samsung,power-domain =<&gsc_pd>;
};
+
+ tmu_cpu0: tmu@10060000 {
+ compatible = "samsung,exynos5420-tmu";
+ reg =<0x10060000 0x100>;
+ interrupts =<0 65 0>;
+ clocks =<&clock 318>;
+ clock-names = "tmu_apbif";
+ };
+
+ tmu_cpu1: tmu@10064000 {
+ compatible = "samsung,exynos5420-tmu";
+ reg =<0x10064000 0x100>;
+ interrupts =<0 183 0>;
+ clocks =<&clock 318>;
+ clock-names = "tmu_apbif";
+ };
+
+ tmu_cpu2: tmu@10068000 {
+ compatible = "samsung,exynos5420-tmu-ext-triminfo";
+ reg =<0x10068000 0x100>,<0x1006c000 0x4>;
+ interrupts =<0 184 0>;
+ clocks =<&clock 318>,<&clock 318>;
+ clock-names = "tmu_apbif", "tmu_triminfo_apbif";
+ };
+
+ tmu_cpu3: tmu@1006c000 {
+ compatible = "samsung,exynos5420-tmu-ext-triminfo";
+ reg =<0x1006c000 0x100>,<0x100a0000 0x4>;
+ interrupts =<0 185 0>;
+ clocks =<&clock 318>,<&clock 319>;
+ clock-names = "tmu_apbif", "tmu_triminfo_apbif";
+ };
+
+ tmu_gpu: tmu@100a0000 {
+ compatible = "samsung,exynos5420-tmu-ext-triminfo";
+ reg =<0x100a0000 0x100>,<0x10068000 0x4>;
+ interrupts =<0 215 0>;
+ clocks =<&clock 319>,<&clock 318>;
+ clock-names = "tmu_apbif", "tmu_triminfo_apbif";
+ };
};

Looks good to me, applied.
Merry Christmas :-)

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/