Re: [PATCHv2 1/3] silicom: fix whitespace issues in bypass.c

From: Greg Kroah-Hartman
Date: Fri Dec 20 2013 - 12:01:55 EST


On Fri, Dec 20, 2013 at 08:36:48PM +0530, Gokulnath A wrote:
> Hello Michael,
>
> On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
> <michael.hoefler@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > This patch addresses several problems in bypass.c found by checkpatch.
> > Furthermore it removes/adds some empty lines to make the code more readable.
> >
> > The following problems are fixed:
> > - line over 80 characters
> > - space after logical operator !
> > - spaces instead of tabs
> > - missing empty line after local declarations
> > - empty line after {
> >
>
> Please do one thing per patch, As Greg suggested for me in previous mail
> conversations. Here you could have at least 3 or 4 patches.
> For example, first patch would be a fix for line over 80 characters,
> followed by the other problems as mentioned above by you.

Nah, all of these are affecting the same macros, so it's ok, I'll take
it as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/