Re: [PATCH net-next] hyperv: Add support for Virtual Receive SideScaling (vRSS)

From: Tom Herbert
Date: Thu Dec 19 2013 - 18:37:43 EST


On Thu, Dec 19, 2013 at 3:15 PM, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> wrote:
>> -----Original Message-----
>> From: Tom Herbert [mailto:therbert@xxxxxxxxxx]
>> Sent: Thursday, December 19, 2013 4:43 PM
>> To: Haiyang Zhang
>> Cc: Daniel Borkmann; Ben Hutchings; davem@xxxxxxxxxxxxx;
>> netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx;
>> jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
>> devel@xxxxxxxxxxxxxxxxxxxxxx
>> Subject: Re: [PATCH net-next] hyperv: Add support for Virtual Receive Side
>> Scaling (vRSS)
>>
>> Patch is below. This version did most pre-computation of the variants I built,
>> but results in largest table (40*256*4 bytes), This gives performance roughly
>> comparable with jhash (roughly same as jhash for IPv4, about 30% more
>> cycles for IPv6). I have the simpler less memory intensive versions also if
>> you're interested, these are 10x worse cycles so I wouldn't want those in
>> critical path.
>> ----
>
> Thank you for the code. We like the fast implementation even it uses a bit more
> memory. Are you going to address the comments and re-submit the code soon?
>
I'll take another look now that there's some new motivation :-)

> Thanks,
> - Haiyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/