Re: [PATCH 3/3] drivers: pcmcia: Include appropriate header file in cardbus.c

From: Bjorn Helgaas
Date: Thu Dec 19 2013 - 13:15:04 EST


On Thu, Dec 19, 2013 at 1:36 AM, Rashika Kheria
<rashika.kheria@xxxxxxxxx> wrote:
> Include appropriate header file cs_internal.h in cardbus.c because
> functions cb_alloc() and cb_free() have their prototype declarations in
> cs_internal.h.
>
> This eliminates the following warnings in cardbus.c:
> drivers/pcmcia/cardbus.c:67:11: warning: no previous prototype for âcb_allocâ [-Wmissing-prototypes]
> drivers/pcmcia/cardbus.c:105:6: warning: no previous prototype for âcb_freeâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Applied to my pci/misc branch for v3.14, thanks!

Bjorn

> ---
> drivers/pcmcia/cardbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c
> index b2a98cd..1c85f4b 100644
> --- a/drivers/pcmcia/cardbus.c
> +++ b/drivers/pcmcia/cardbus.c
> @@ -25,7 +25,7 @@
> #include <linux/pci.h>
>
> #include <pcmcia/ss.h>
> -
> +#include "cs_internal.h"
>
> static void cardbus_config_irq_and_cls(struct pci_bus *bus, int irq)
> {
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/