Re: [PATCH v2] drivers: base: Add prototype declaration to theheader file

From: Greg Kroah-Hartman
Date: Thu Dec 19 2013 - 13:14:02 EST


On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote:
> Add prototype declaration of function memory_block_size_bytes() to
> the header file include/linux/memory.h.
>
> This eliminates the following warning in memory.c:
> drivers/base/memory.c:87:1: warning: no previous prototype for âmemory_block_size_bytesâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Please ALWAYS run your patches through checkpatch.pl so a maintainer
doesn't have to write you an email like this reminding you to do that...

Josh, come on, you should have caught this as well, fix up your email
client to flag stuff like this easier...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/