Re: [PATCH 1/7] drivers: usb: Include appropriate header file in hcd.c

From: Rashika Kheria
Date: Thu Dec 19 2013 - 11:41:51 EST


On Thu, Dec 19, 2013 at 10:06 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Dec 19, 2013 at 03:36:00PM +0530, Rashika Kheria wrote:
>> Include appropriate header file include/linux/usb/otg.h in core/hcd.c
>> because function usb_bus_start_enum() has its prototype declaration in
>> include/linux/usb/otg.h.
>>
>> This eliminates the following warning in core/hcd.c:
>> drivers/usb/core/hcd.c:2295:5: warning: no previous prototype for ‘usb_bus_start_enum’ [-Wmissing-prototypes]
>
> What is generating this warning? I don't see it here on my machines,
> nor do I see any of the other warnings you have fixed in this series.
> How do I duplicate them?
>
> thanks,
>
> greg k-h

Hi Greg,

These warning are non-default GCC warnings. These can be seen either
by adding W=1 while running make (i.e. make W=1) or adding
-Wmissing-prototypes in KBUILD_CFLAGS in the toplevel Makefile.

Thanks,
--
Rashika Kheria
B.Tech CSE
IIIT Hyderabad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/