Re: [PATCH 0/4] Add support of guest user space symbols for perf kvmcommand.

From: Ingo Molnar
Date: Thu Dec 19 2013 - 10:35:03 EST



* Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx> wrote:

> Em Thu, Dec 19, 2013 at 05:54:50PM -0500, Dongsheng Yang escreveu:
> > Hi all,
> > This patch add support of guest user space symbols for perf kvm command.
>
> Cool stuff! Please see some comments on the patches, with requests for
> possible patch splits and better changeset comments.
>
> > Example:
> > # perf kvm --guestmount /tmp/guestmount/ top
> > Samples: 1K of event 'cycles', Event count (approx.): 259112905

Btw., having to specify a '--guestmount /tmp/guestmount/' just to
achieve a natural feature (proper guest symbol resolution) is a poor
user interface, obviously.

Is there perhaps a predictable pattern as to where qemu (or libvirt)
puts a user's guest mounts, or some other discovery method?

If yes then it would be possible to automatically look for that
pattern, and use the guest filesystem when it's available, without the
user having to manually configure the path.

( Ideally we'd have kernel help for discovering this, but last time I
raised that with the KVM folks there was resistence. )

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/