Re: [PATCH 3/6] perf tools: Get rid of a duplicate va_end()

From: Jiri Olsa
Date: Thu Dec 19 2013 - 08:32:35 EST


On Thu, Dec 19, 2013 at 04:00:08PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> The va_end() in _eprintf() should be removed since the caller also
> invokes va_end().
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

jirka

> ---
> tools/perf/util/debug.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
> index 8640a9121e72..299b55586502 100644
> --- a/tools/perf/util/debug.c
> +++ b/tools/perf/util/debug.c
> @@ -25,7 +25,6 @@ static int _eprintf(int level, const char *fmt, va_list args)
> ui_helpline__vshow(fmt, args);
> else
> ret = vfprintf(stderr, fmt, args);
> - va_end(args);
> }
>
> return ret;
> --
> 1.7.11.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/