Re: [PATCH 1/2] mfd: AS3722: add dt node properties for system powercontroller

From: Lee Jones
Date: Thu Dec 19 2013 - 08:06:28 EST


On Thu, 19 Dec 2013, Laxman Dewangan wrote:

> ams AS3722 device supports the power off by turning off its all rails.
>
> Add dt node properties to enable this functionality on this device.
>
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/as3722.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index fc2191e..1e54937 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -112,6 +112,15 @@ Following are properties of regulator subnode.
> ams,enable-tracking: Enable tracking with SD1, only supported
> by LDO3.
>
> +Power-off:
> +=========
> +AS3722 supports the system power off by turning off all its rail. The power off
> +is provided through pm power off.

I think pm_power_off is a Linuxisum.

> +The device node should have the following properties to enable power-off

Why is it power-off here and power off everywhere else?

> +functionality from ams AS3722:
> +ams,system-power-controller: To enable the power off functionality through
> + device.

Do what with it? "on", "<1>", something else?

> Example:
> --------
> #include <dt-bindings/mfd/as3722.h>

Should it be represented in the example?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/