Re: [PATCH linux-3.10.y] ip6tnl: fix use after free of fb_tnl_dev

[Nicolas Dichtel]

Le 19/12/2013 11:07, Luis Henriques a écrit :
> On Tue, Dec 17, 2013 at 02:40:02PM -0500, David Miller wrote:
> > From: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> > Date: Fri, 13 Dec 2013 10:06:35 +0100
> >
> > > The upstream commit bb8140947a24 ("ip6tnl: allow to use rtnl ops on fb tunnel")
> > > (backported into linux-3.10.y) left a bug which was fixed upstream by commit
> > > 1e9f3d6f1c40 ("ip6tnl: fix use after free of fb_tnl_dev").
> > >
> > > The problem is a bit different in linux-3.10.y, because there is no x-netns
> > > support (upstream commit 0bd8762824e7 ("ip6tnl: add x-netns support")).
> > > When ip6_tunnel.ko is unloaded, FB device is deleted by rtnl_link_unregister()
> > > and then we try to delete it again in ip6_tnl_destroy_tunnels().
> > >
> > > This patch removes the second deletion.
> > >
> > > Reported-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> >
> > Greg please queue this up for 3.10 -stable if you haven't already.
>
> As I'm picking the networking patches into the 3.11 kernel as well, I
> believe this fix is also applicable.  I'm queuing it for the 3.11 kernel.
Yes, I agree.


Regards,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/