RE: [PATCH 2/3] drivers: rapidio: Include appropriate header filein rio-driver.c

From: Bounine, Alexandre
Date: Wed Dec 18 2013 - 13:23:11 EST


On Sat, Dec 14, 2013 at 7:50AM, Rashika Kheria wrote:
> Subject: [PATCH 2/3] drivers: rapidio: Include appropriate header file
> in rio-driver.c
>
> This patch includes the header file linux/rio_drv.h in rio-driver.c
> because functions rio_dev_get(), rio_dev_put(), rio_register_driver()
> and rio_unregister_driver() have their prototype declarations in
> linux/rio_drv.h.
>
> Thus, it also eliminates the following warnings in rio-driver.c:
>
> drivers/rapidio/rio-driver.c:57:17: warning: no previous prototype for
> ârio_dev_getâ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:74:6: warning: no previous prototype for
> ârio_dev_putâ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:143:5: warning: no previous prototype for
> ârio_register_driverâ [-Wmissing-prototypes]
> drivers/rapidio/rio-driver.c:162:6: warning: no previous prototype for
> ârio_unregister_driverâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> ---
> drivers/rapidio/rio-driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/rapidio/rio-driver.c b/drivers/rapidio/rio-
> driver.c
> index c9ae692..df73419 100644
> --- a/drivers/rapidio/rio-driver.c
> +++ b/drivers/rapidio/rio-driver.c
> @@ -13,6 +13,7 @@
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/rio.h>
> +#include <linux/rio_drv.h>
> #include <linux/rio_ids.h>
>
> #include "rio.h"
> --
> 1.7.9.5

Acked-by: Alexandre Bounine <alexandre.bounine@xxxxxxx>

èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—