Re: [PATCH 1/2] drivers: ide: Include appropriate header file inide-cd_verbose.c

[Sergei Shtylyov]

Hello.

On 12/17/2013 02:08 PM, Rashika Kheria wrote:

> Include appropriate header file ide-cd.h in ide-cd_verbose.c because
> function ide_cd_log_error() has its prototype declaration in ide-cd.h.
> Also, include linux/ide.h because it contains certain declarations
> necessary for including ide-cd.h.

   You should fix "ide-cd.h" if it depends on <linux/ide.h>, not the .c file 
including it.

> This eliminates the following warnings in ide-cd_verbose.c:
> drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for âide_cd_log_errorâ [-Wmissing-prototypes]

> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/