Re: [PATCH 04/15] perf, x86: Use context switch callback to flushLBR stack

[Ingo Molnar]

* Yan, Zheng <zheng.z.yan@xxxxxxxxx> wrote:

> From: "Yan, Zheng" <zheng.z.yan@xxxxxxxxx>
> 
> Enable pmu context switch callback if LBR is used. Use the callback
> to flush LBR stack when process is scheduled in.
> 
> Signed-off-by: Yan, Zheng <zheng.z.yan@xxxxxxxxx>

I see several fundamental problems with your series:

1)

Minimal changelogs like the ones in this series are completely 
unacceptable! You seem to be copying the changelog style of Andi 
Kleen: written to inform as little as possible.

Don't do that if you want your patches to get anywhere, instead adapt 
the akpm style:

 "Please update the changelog to describe the current behavior.

  Please also describe why you think that behavior should be changed.
  ie: what's the reason for this patch.
 "

2)

Also, there are frequent typos.

3)

Plus you didn't Cc: other perf maintainers like myself or Arnaldo.

4)

How can users actually make use of the changes you are doing? Cite 
actual perf analysis usecases in the 0/15 description and describe how 
your patches improve/enable all that.

Please fix all those problems and resend.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/