Re: [PATCH 00/15] cleanups and optimizations

From: Peter Zijlstra
Date: Tue Dec 17 2013 - 10:14:16 EST


On Tue, Dec 17, 2013 at 04:03:58PM +0200, Eliezer Tamir wrote:
> n 17/12/2013 15:32, Peter Zijlstra wrote:
> >
> > Awesomeness.. you'll work on subtracting the spin time from the sleep
> > time?
>
> Me or someone on our team will work on it.
>
> I'm not sure that subtracting the spin time is the optimal thing to do.
>
> The busy poll time is supposed to be limited to something less than 1ms.
> (I'm using 50us in most of my tests)
> This is typically orders of magnitude smaller than the poll timeout.
> Would it make more sense to just enforce a limit on poll time?
>
> What do you think?

I've no idea what people normally expect of select/poll wakeup
granularity but typically we already have 50us of timer slack, although
RT tasks go without this.

It shouldn't be too hard to simply subtract the busy wait from the
expire ktime and avoid the entire issue though, so why not DTRT if its
fairly straight fwd to do so?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/