Re: [PATCH] regmap: Allow regmap_bulk_read() to work for "no-bus"regmaps

From: Mark Brown
Date: Mon Dec 16 2013 - 15:57:24 EST


On Fri, Dec 13, 2013 at 09:14:07AM -0800, Stephen Boyd wrote:

> regmap_bulk_read() should decay to performing individual reads if
> we're using a "no-bus" regmap. Unfortunately, it returns an
> error because there is no map->bus pointer. Fix it.

Applied, thanks.

> > Yes, I'd expect the operation to work. Your changes below are mostly
> > fine (we should add an additional check for values that aren't integer
> > numbers of bytes, I can add that) - can you send as a signed off patch
> > please and I'll apply?

> Here you go. Do you have any suggestions on how to make regmap_bulk_write()
> work?

Off the top of my head I'd expect it to just fall back onto
regmap_write() if it can't do raw I/O. Or perhaps just change that loop
to do regmap_write() all the time since it's hardly the fast path.

Attachment: signature.asc
Description: Digital signature