Re: [PATCH v2 1/2] printk: Add a pr_warn_deprecated macro

[Joe Perches]

(adding Andrew Morton to cc's)

On Mon, 2013-12-16 at 12:06 -0500, Neil Horman wrote:
> sctp has several points in its setsockopt path in which it issues deprecation
> warnings.  It seems like it might be handy to macrotize such a warning so other
> subsystems can use it easily
[]
> diff --git a/include/linux/printk.h b/include/linux/printk.h
[]
> @@ -336,6 +336,9 @@ extern asmlinkage void dump_stack(void) __cold;
>  	printk_ratelimited(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>  /* no pr_cont_ratelimited, don't do that... */
>  
> +#define pr_warn_deprecated(fmt, ...)					\
> +	pr_warn_ratelimited("Deprecated: " fmt, ##__VA_ARGS__)

Continuing the thread from:
http://patchwork.ozlabs.org/patch/301738/

Making this a global kernel #define is different than
using it in your subsystem.

I think this is very analogous to the FW_INFO/FW_WARN
uses and maybe should just have a #define for the
string "deprecated:" inserted as a constant.

ie: just using

	pr_warn_once(DEPRECATED fmt, args...)
or
	pr_warn_ratelimited(DEPRECATED fmt, args...)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/