RE: [PATCH v2] ASoC: SGTL5000: Fix kernel failed while trying toget optional VDDD supply.

From: Li.Xiubo@xxxxxxxxxxxxx
Date: Sun Dec 15 2013 - 22:48:50 EST



> > 2, If the regulator dt node is exist but the optional VDDD is absent (i.e.
> > The external VDDD is not used), a -EPROBE_DEFER will be returned, if
> > just return the -EPROBE_DEFER to the probe(and then the probe deferral
> > mechanism will do the probe again later, is that right ?), and then
> > the
> > regulator_get_optional() will be called later again, and the
> > -EPROBE_DEFER will be returned again too, and now how should I handle
> > -EPROBE_DEFER error twice ? Or should there be a counter about this ?
> > That to say when the -EPROBE_DEFER error is the second time returned
> > from regulator_get_optional() can we ensure that the optional VDDD is really
> not in use.
>
> The driver should just defer when it's told to defer, I don't understand why it
> would want to count anything?
>

It's just one idea for the special handling of regulator_get_optional() in this
case.

--
Xiubo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/