Re: [PATCH v5 10/14] efi: only print saved efi runtime maps insteadof all memmap ranges for kexec

[Dave Young]

> > -	print_efi_memmap();
> > +	if (efi_setup) {
> > +		int s;
> > +		struct efi_setup_data *data;
> > +
> > +		s = sizeof(*data) + nr_efi_runtime_map * sizeof(data->map[0]);
> > +		data = early_memremap(efi_setup, s);
> > +		if (!data)
> > +			return;
> > +		print_efi_memmap(data->map, nr_efi_runtime_map,
> > +				 sizeof(data->map[0]));
> > +		early_memunmap(data, s);
> 
> Well, if you call print_efi_memmap() in parse_efi_setup() you can save
> yourself that map/unmaping no?

In parse_efi_setup, I need map twice as well:
  mapping sizeof(struct setup_data) to get the payload len, then mapping
  the data->map again and call print_efi_memmap..

Another where what I print in this patch is same position what non-kexec kernel
does, it looks better that print them only if earlier init is ok. 

--
Thanks for review
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/