Re: [PATCH 1/2] ion: Don't allow building ION as a module.

[Greg KH]

On Sat, Dec 14, 2013 at 12:06:45PM -0800, John Stultz wrote:
> ION doesn't export the proper symbols for it to be a module. This
> causes build issues when ION is configured as a module.
> 
> Since Andorid kernels rarely use modules (I think recent policy
> requires no modules?), go ahead and set the ION config to a bool
> from the tristate option.
> 
> If folks decide ION as a module is important, we will have to go
> through and export the various needed symbols.
> 
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
>  drivers/staging/android/ion/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index a342d96..b95281e 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -1,5 +1,5 @@
>  menuconfig ION
> -	tristate "Ion Memory Manager"
> +	bool "Ion Memory Manager"

Or you can do:
	depends on m
and leave it as a "tristate", then when switching it off, I think you
can then be prompted as 'm' again, but I could be wrong about that.

So should ION ever be able to be built as a module in the future?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/