Re: [PATCH 2/3] drivers: edac: Mark the functionedac_create_debug_nodes() as static in edac_mc_sysfs.c

[Josh Triplett]

On Sat, Dec 14, 2013 at 07:30:11PM +0530, Rashika Kheria wrote:
> This patch marks the function edac_create_debug_nodes() as static in
> edac_mc_sysfs.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warning in edac_mc_sysfs.c:
> drivers/edac/edac_mc_sysfs.c:917:5: warning: no previous prototype for âedac_create_debug_nodesâ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

>  drivers/edac/edac_mc_sysfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
> index 9f7e0e60..51c0362 100644
> --- a/drivers/edac/edac_mc_sysfs.c
> +++ b/drivers/edac/edac_mc_sysfs.c
> @@ -914,7 +914,7 @@ void __exit edac_debugfs_exit(void)
>  	debugfs_remove(edac_debugfs);
>  }
>  
> -int edac_create_debug_nodes(struct mem_ctl_info *mci)
> +static int edac_create_debug_nodes(struct mem_ctl_info *mci)
>  {
>  	struct dentry *d, *parent;
>  	char name[80];
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/