Re: [lm-sensors] [PATCH 00/12] i8k patch series

[Guenter Roeck]

On 12/14/2013 11:03 AM, Jean Delvare wrote:
> On Sat, 14 Dec 2013 19:45:19 +0100, Arnd Bergmann wrote:
> > On Saturday 14 December 2013, Guenter Roeck wrote:
> > > Clean up and simplify the driver, add support for additional temperature
> > > sensors, fix a problem seen with multi-core CPU, and add support
> > > for additional systems.
> > >
> > > ----------------------------------------------------------------
> > > Guenter Roeck (14):
> > >        i8k: Convert to use pr_ functions instead of printk
> > >        i8k: Fix various checkpatch warnings and errors
> > >        i8k: Convert to use to hwmon_device_register_with_groups hwmon API
> > >        i8k: Support additional temperature sensors
> > >        MAINTAINERS: Add myself as i8k maintainer
> > >        i8k: Remove obsolete link to out-of-tree driver
> > >        i8k: Drop driver version number and info message at startup
> > >        i8k: Force SMM to run on CPU 0
> > >        i8k: Add copyright
> > >        i8k: Add support for Dell Studio laptops
> > >        i8k: Add support for Dell XPS M140
> > >        i8k: Use driver_data field of dmi_system_id to override fan multiplier
> > >        i8k: Stop reading SMM BIOS version during driver probe
> > >        i8k: Implement hwmon based fan speed control
> > >
> > >   MAINTAINERS        |    2 +-
> > >   drivers/char/i8k.c |  358 +++++++++++++++++++++++++++++-----------------------
> > >   2 files changed, 201 insertions(+), 159 deletions(-)
> >
> > All changes in this patch set look good to me.
> >
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > I wonder if it makes sense to move the driver to drivers/platform/x86/, which
> > has a bunch of similar ones already.
>
> That would be a good idea IMHO.

I agree; drivers/char doesn't seem to be a good location. Guess it is mostly historic
that it is there in the first place. Maybe it can even use the API provided by the
dell-laptop driver if I can ever figure out how that works.

Copying the platform-x86 mailing list and Matthew for additional input.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/