Re: [PATCH] drivers: reset: Mark function as static in core.c

[Dan Carpenter]

On Sat, Dec 14, 2013 at 06:56:10PM +0530, Rashika Kheria wrote:
> This patch marks the function of_reset_simple_xlate() and
> devm_reset_control_put() as static in core.c because it is not used
> outside this file.
> 
> Thus, it also eliminate the following warnings in core.c:
> drivers/reset/core.c:46:5: warning: no previous prototype for âof_reset_simple_xlateâ [-Wmissing-prototypes]
> drivers/reset/core.c:262:6: warning: no previous prototype for âdevm_reset_control_putâ [-Wmissing-prototypes]
> 

These are EXPORT_SYMBOL_GPL() so that doesn't make sense.
devm_reset_control_put() is not used at all and of_reset_simple_xlate()
doesn't look like it needs to be exported.  Philipp?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/