Re: [PATCH 1/5] xfs: factor prid related codes into xfs_get_initial_prid()

[Zhi Yong Wu]

On Sat, Dec 14, 2013 at 7:20 PM, Jeff Liu <jeff.liu@xxxxxxxxxx> wrote:
> On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>>> +{
>>> +    if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>>> +            return xfs_get_projid(dp);
>>> +    else
>>> +            return XFS_PROJID_DEFAULT;
>>> +}
>>
>> You could skip the else here.
> Except that, I'd suggest we move this helper to proper header file with
> further refactoring in xfs_symlink(), and it could be a separate patch.
Good point, will apply it, thanks.

>
> Thanks,
> -Jeff



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/