Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

[John Stultz]

On 12/13/2013 03:50 PM, Greg KH wrote:
> On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote:
>> From: Rebecca Schultz Zavin <rebecca@xxxxxxxxxxx>
>>
>> Signed-off-by: Rebecca Schultz Zavin <rebecca@xxxxxxxxxxx>
>> [jstultz: Squished in Colin Cross' move to staging change]
>> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
>> ---
>>  drivers/staging/android/Kconfig                 |    2 +
>>  drivers/staging/android/Makefile                |    2 +
> This patch breaks the build if this option is enabled.
>
> I suggest only adding the driver to the build _after_ it can be built,
> for obvious reasons :)

Right. Until recently it really only builds on ARM. There's a patch
which adds that dependency (and then later removes it once other fixes
land), but its later in the patch series.

Apologies.

> Other than this "minor" thing, I have no objection to these patches at
> all.  Can you redo this patch to fix this up, and maybe send another
> patch adding it to the build and let me know at what point in the series
> it should be applied?
I'll squish that config dependency down to the first patch and go
through verifying it builds.

> Also, I only received 92 of these patches, not all 115, are they stuck
> somewhere in a mail queue?
Maybe? I hope! I've never played GregKH and sent such a large patchset
before!

thanks
-john



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/