Re: [PATCH 2/5] drivers: misc: Mark functions as static in xp_main.c

[Robin Holt]

On Fri, Dec 13, 2013 at 2:56 AM, Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Dec 13, 2013 at 12:21:20PM +0530, Rashika Kheria wrote:
>> This patch marks the function xp_init() and xp_exit() as static in
>> sgi-xp/xp_main.c because they are not used outside this file.
>>
>> Thus, it also eliminates the following warnings in sgi-xp/xp_main.c:
>> drivers/misc/sgi-xp/xp_main.c:249:1: warning: no previous prototype for ‘xp_init’ [-Wmissing-prototypes]
>> drivers/misc/sgi-xp/xp_main.c:274:1: warning: no previous prototype for ‘xp_exit’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
Acked-by: Robin Holt <robinmholt@xxxxxxxxx>

>
>>  drivers/misc/sgi-xp/xp_main.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/misc/sgi-xp/xp_main.c b/drivers/misc/sgi-xp/xp_main.c
>> index 01be66d..df14c70 100644
>> --- a/drivers/misc/sgi-xp/xp_main.c
>> +++ b/drivers/misc/sgi-xp/xp_main.c
>> @@ -245,7 +245,7 @@ xpc_disconnect(int ch_number)
>>  }
>>  EXPORT_SYMBOL_GPL(xpc_disconnect);
>>
>> -int __init
>> +static int __init
>>  xp_init(void)
>>  {
>>       enum xp_retval ret;
>> @@ -270,7 +270,7 @@ xp_init(void)
>>
>>  module_init(xp_init);
>>
>> -void __exit
>> +static void __exit
>>  xp_exit(void)
>>  {
>>       if (is_shub())
>> --
>> 1.7.9.5
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/