[RFC PATCH 2/5] xen-pciback: First reset, then free.

From: Konrad Rzeszutek Wilk
Date: Fri Dec 13 2013 - 11:25:34 EST


We were doing the operations of freeing and reset in the wrong
order. Granted nothing broke b/c the reset functions just
set bar->which = 0.

But nonethless this was incorrect.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
drivers/xen/xen-pciback/pci_stub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 5300a21..36dd4f3 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -278,8 +278,8 @@ void pcistub_put_pci_dev(struct pci_dev *dev)
xen_pcibk_reset_device(dev);

/* And cleanup up our emulated fields. */
- xen_pcibk_config_free_dyn_fields(dev);
xen_pcibk_config_reset_dev(dev);
+ xen_pcibk_config_free_dyn_fields(dev);

xen_unregister_device_domain_owner(dev);

--
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/